Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modular infrastructure providers using Sveltos templates #874

Closed
wants to merge 6 commits into from
Closed

Modular infrastructure providers using Sveltos templates #874

wants to merge 6 commits into from

Conversation

s3rj1k
Copy link
Collaborator

@s3rj1k s3rj1k commented Jan 9, 2025 •
edited
Loading

Modular infrastructure providers using Sveltos templates (#919)

  • Consolidates cloud provider credential managers under a common interface.
  • Adds reconciliation of infrastructure provider resources using Sveltos profile templates.
  • Removes credential propagation logic.
  • Migrates credential propagation logic into Sveltos profile template.
  • Remove unused code.

s3rj1k
s3rj1k commented Jan 9, 2025
View reviewed changes
internal/providers/azure.go Outdated Show resolved Hide resolved
@s3rj1k s3rj1k force-pushed the provider-modules-sveltos-templates branch from ac61def to e92e0cb Compare January 9, 2025 17:22
@s3rj1k s3rj1k marked this pull request as ready for review January 10, 2025 15:06
@s3rj1k s3rj1k force-pushed the provider-modules-sveltos-templates branch from e92e0cb to ed15e00 Compare January 10, 2025 19:31
zerospiel
zerospiel reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@zerospiel zerospiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the approach looks good to me, i left a couple of questions and minors regarding the code

internal/providers/providers.go Outdated Show resolved Hide resolved
internal/controller/clusterdeployment_controller.go Outdated Show resolved Hide resolved
cmd/main.go Show resolved Hide resolved
internal/providers/providers.go Show resolved Hide resolved
@s3rj1k s3rj1k force-pushed the provider-modules-sveltos-templates branch 2 times, most recently from bf6c2c0 to 507dae0 Compare January 13, 2025 09:54
zerospiel
zerospiel reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@zerospiel zerospiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the PR then requires other follow-up PRs regarding further migration of the providers (please see the comment)

I do not approve the PR to avoid accidental merges until the other teammebers also check it out

@s3rj1k s3rj1k force-pushed the provider-modules-sveltos-templates branch from 507dae0 to ad47324 Compare January 14, 2025 11:49
@s3rj1k s3rj1k requested a review from eromanova as a code owner January 14, 2025 11:49
@s3rj1k s3rj1k force-pushed the provider-modules-sveltos-templates branch 4 times, most recently from 63028dd to 8c16102 Compare January 15, 2025 23:41
@s3rj1k s3rj1k force-pushed the provider-modules-sveltos-templates branch from 8c16102 to 878bdcb Compare January 16, 2025 15:29
@s3rj1k s3rj1k force-pushed the provider-modules-sveltos-templates branch from 878bdcb to 694c1aa Compare January 16, 2025 18:32
@s3rj1k s3rj1k force-pushed the provider-modules-sveltos-templates branch 4 times, most recently from a85e8f5 to c83092d Compare January 17, 2025 18:50
@s3rj1k s3rj1k force-pushed the provider-modules-sveltos-templates branch from c83092d to 799d3ba Compare January 20, 2025 09:17
@s3rj1k s3rj1k marked this pull request as draft January 20, 2025 18:56
@s3rj1k
Copy link
Collaborator Author

s3rj1k commented Jan 20, 2025

Adopted to new changes PR is here #925

@s3rj1k
Copy link
Collaborator Author

s3rj1k commented Jan 22, 2025

Closing due to merged #925

@s3rj1k s3rj1k closed this Jan 22, 2025
@s3rj1k s3rj1k deleted the provider-modules-sveltos-templates branch January 22, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerospiel zerospiel zerospiel left review comments

@Kshatrix Kshatrix Awaiting requested review from Kshatrix Kshatrix is a code owner

@a13x5 a13x5 Awaiting requested review from a13x5 a13x5 is a code owner

@eromanova eromanova Awaiting requested review from eromanova eromanova is a code owner

Assignees
No one assigned
Labels
None yet
Projects
k0rdent
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s3rj1k @zerospiel